Spelling - #404
Spelling#404aeisenberg merged 1 commit into
Conversation
Sorry, something went wrong.
| if ((config.paths.length !== 0 || config.pathsIgnore.length !== 0) && | ||
| !config.languages.every(isInterpretedLanguage)) { | ||
| logger.warning('The "paths"/"paths-ignore" fields of the config only have effect for Javascript and Python'); | ||
| logger.warning('The "paths"/"paths-ignore" fields of the config only have effect for JavaScript and Python'); |
There was a problem hiding this comment.
This is a brand
Sorry, something went wrong.
| }); | ||
| }); | ||
| ava_1.default('download codeql bundle cache with pinned different version cached if "latests" tools specified', async (t) => { | ||
| ava_1.default('download codeql bundle cache with pinned different version cached if "latest" tools specified', async (t) => { |
There was a problem hiding this comment.
I can understand this being intentional, I don't think it's a valuable spelling divergence.
Sorry, something went wrong.
| logger.startGroup("Setup Python dependencies"); | ||
| const scriptsFolder = path.resolve(__dirname, "../python-setup"); | ||
| // Setup tools on the Github hosted runners | ||
| // Setup tools on the GitHub hosted runners |
There was a problem hiding this comment.
This is a brand
Sorry, something went wrong.
| * Removes any API prefix or suffix if one is present. | ||
| */ | ||
| function parseGithubUrl(inputUrl) { | ||
| function parseGitHubUrl(inputUrl) { |
There was a problem hiding this comment.
This is clearly an API, but if it's an internal API, then it's worth changing.
If it's from an upstream library, I'd be more than happy to try to get it changed.
I can also easily drop the API change from the general brand change -- just let me know.
Sorry, something went wrong.
aeisenberg
left a comment
There was a problem hiding this comment.
Thanks for submitting your PR! Most of your changes look reasonable.
You need to re-run npm run build in order to get all the compiled javascript corrected. Also, see my comment about removing the changes to the sarif spec file.
Sorry, something went wrong.
|
@aeisenberg: yeah, I've already made the PR to them; dropped here. Updated the map. I also have a set on en_US changes which I imagined might be controversial, so I left them out of this PR. This repository appears to have a mix of en_US/en_GB. I generally encourage repositories to use only one flavor of English... I can offer a PR to adopt either flavor. |
Sorry, something went wrong.
|
Failing build checks are unrelated to this change and are fixed in main. |
Sorry, something went wrong.
I don't think we have a policy on this. Feel free to open a separate PR and we can discuss. |
Sorry, something went wrong.
spelling: executable spelling: github spelling: javascript spelling: latest spelling: occurred spelling: parameter Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
|
Rebased and squashed. |
Sorry, something went wrong.
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@525c790#commitcomment-47650569
The action reports that the changes in this PR would make it happy: jsoref@42808db
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.
Merge / deployment checklist