| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Adds a standalone TypeScript CLI for validating change-note files.
Changes:
| File | Description |
|---|---|
| scripts/changetool/index.ts | Implements CLI dispatch and exit codes. |
| scripts/changetool/cli/validate.ts | Implements change-note validation. |
| scripts/changetool/cli/validate.test.ts | Tests validation behavior. |
| scripts/changetool/package.json | Defines scripts and dependencies. |
| scripts/changetool/package-lock.json | Locks package dependencies. |
| scripts/changetool/tsconfig.json | Configures TypeScript compilation. |
| eslint.config.mjs | Adds changetool lint configuration. |
| .github/workflows/pr-checks.yml | Adds a dedicated test job. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Files not reviewed (1)
Sorry, something went wrong.
`.every()` short-circuits on the first `false`
Apparently, the `in` operator will check inherited properties too.
There was a problem hiding this comment.
Nice, just a couple of minor package.json suggestions:
Sorry, something went wrong.
Co-authored-by: Henry Mercer <henrymercer@github.com>
There was a problem hiding this comment.
@mario-campos @henrymercer Obviously a late comment, but I am wondering about the motivation for moving this to a separate project in scripts/changetool? I don't see the reasoning explained here, but wouldn't it have kept things simpler to have it in pr-checks along with the other changelog related code?
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR introduces a distinct NPM package/script under scripts/changetool for the purpose of validating change-notes (and eventually, in a subsequent PR, merging change-notes into CHANGELOG.md).
Presently, this script has only one command, validate (executed as npm --workspace changetool start validate), which accepts path(s) to change-note files to be validated. Any flaws in the change-notes are described in the output, and the command will exit with 1.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist