Don't upload the ESLint SARIF from merge queue refs - #4125
Merged
henrymercer merged 1 commit intoSep 4, 2026
Merged
henrymercer merged 1 commit into
henrymercer merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused workflow change has no unresolved issues.
Review tier: Balanced
Findings: None
Prevents transient merge-queue failures by skipping ESLint SARIF uploads for ephemeral queue refs.
Changes:
- Adds a ref-based guard for gh-readonly-queue refs.
- Documents coverage of merge-group and paired push runs.
| File | Description |
|---|---|
| .github/workflows/pr-checks.yml | Skips ESLint SARIF uploads from merge-queue refs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
henrymercer
marked this pull request as ready for review
September 4, 2026 16:27
mbg
approved these changes
Sep 4, 2026
mbg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good observation. Thanks for noticing and fixing it! The fix looks sensible to me.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Unit Tests job uploads its ESLint SARIF via upload-sarif, gated only on OS and Node version. PR Checks runs on merge_group, and also on push for the gh-readonly-queue branch that the merge queue creates, so in both cases the upload targets a ref that GitHub deletes as soon as the queue entry resolves. When the upload loses that race the code scanning API returns 404 and the step fails.
This accounts for every merge queue failure of PR Checks in the visible run history — five of them, going back to May.
Gate the step on the ref rather than the event, since both the merge_group run and the paired push run use the ephemeral ref. Nothing is lost: alerts on a queue ref are never surfaced, and the same results are uploaded by the pull_request run and again by the push run on main.
codeql.yml already skips its uploads for merge queue runs. It only needs the event check because its push trigger is limited to main and releases/v*.
Lint enforcement is unaffected — lint-ci still fails the job on any lint error. Only the alert upload is skipped.