Improve workflow dispatch for Dependabot PRs - #4137
Open
mbg wants to merge 5 commits into
Open
mbg wants to merge 5 commits into
mbg wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The configured token cannot trigger the intended checks, and unrelated label events can cancel active validation.
4 open issuesGITHUB_TOKEN label events do not trigger required checks · New
Stale Rebuild: Unchanged label suppresses subsequent checks · New
- .github/workflows/__all-platform-bundle.yml: Excluded by your content exclusion settings
- .github/workflows/__analysis-kinds.yml: Excluded by your content exclusion settings
- .github/workflows/__analyze-ref-input.yml: Excluded by your content exclusion settings
- .github/workflows/__autobuild-action.yml: Excluded by your content exclusion settings
- .github/workflows/__autobuild-direct-tracing-with-working-dir.yml: Excluded by your content exclusion settings
- .github/workflows/__autobuild-working-dir.yml: Excluded by your content exclusion settings
- .github/workflows/__build-mode-autobuild.yml: Excluded by your content exclusion settings
- .github/workflows/__build-mode-manual.yml: Excluded by your content exclusion settings
- .github/workflows/__build-mode-none.yml: Excluded by your content exclusion settings
- .github/workflows/__build-mode-rollback.yml: Excluded by your content exclusion settings
- .github/workflows/__bundle-from-nightly.yml: Excluded by your content exclusion settings
- .github/workflows/__bundle-from-toolcache.yml: Excluded by your content exclusion settings
- .github/workflows/__bundle-toolcache.yml: Excluded by your content exclusion settings
- .github/workflows/__cleanup-db-cluster-dir.yml: Excluded by your content exclusion settings
- .github/workflows/__config-export.yml: Excluded by your content exclusion settings
- .github/workflows/__config-input.yml: Excluded by your content exclusion settings
- .github/workflows/__cpp-deptrace-disabled.yml: Excluded by your content exclusion settings
- .github/workflows/__cpp-deptrace-enabled-on-macos.yml: Excluded by your content exclusion settings
- .github/workflows/__cpp-deptrace-enabled.yml: Excluded by your content exclusion settings
- .github/workflows/__diagnostics-export.yml: Excluded by your content exclusion settings
And 37 more.
What changed in this PRThis experiment aims to run CodeQL Action’s generated PR checks for Dependabot updates when rebuilding produces no changes.
Changes:
- Adds label-event triggers and shared job conditions to generated workflows.
- Applies Rebuild: Unchanged after a rebuild reports no changes.
| File | Description |
|---|---|
| pr-checks/sync.ts | Generates label-triggered checks and job conditions. |
| .github/workflows/rebuild.yml | Adds the unchanged-rebuild label. |
Review effort: Max
Sorry, something went wrong.
Comment thread
.github/workflows/rebuild.yml
| github.event_name == 'pull_request' && | ||
| steps.push.outputs.changes != 'true' | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Comment thread
.github/workflows/rebuild.yml
| "Please approve running the PR checks." | | ||
| gh pr comment --body-file - --repo github/codeql-action "$PR_NUMBER" | ||
|
|
||
| - name: "Add 'Rebuild: Unchanged' label" |
Comment thread
.github/workflows/rebuild.yml
| - name: "Add 'Rebuild: Unchanged' label" | ||
| if: >- | ||
| github.event_name == 'pull_request' && | ||
| steps.push.outputs.changes != 'true' |
Comment thread
pr-checks/sync.ts
| }, | ||
| pull_request: {}, | ||
| pull_request: { | ||
| types: ["opened", "synchronize", "reopened", "labeled"], |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment to improve workflow runs for Dependabot PRs in cases where the Rebuild workflow doesn't make any changes. The central idea is that the Rebuild workflow applies a label (Rebuild: Unchanged) to a PR it ran for, but where it made no changes. The label is then used as a trigger for the required workflows.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist