Refactor how the checkout_path input is obtained - #4157
Merged
mbg merged 4 commits intoSep 22, 2026
Merged
mbg merged 4 commits into
mbg merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…out_path` itself
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Copilot review overview
🟡 Changes recommended
Existing analyze-action tests may fail because the new actions-based input lookup is not configured.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1 · 1
Update tests for checkout_path input abstraction · New
Test propagation of configured checkout path to getCommitOid · New
Refactors checkout_path retrieval so the analyze action reads it once and explicitly propagates it.
Changes:
- Passes checkoutPath to diff analysis, caching, and database upload.
- Migrates environment reads to ActionState.env.
- Updates database-upload tests for the new state-based API.
| File | Description |
|---|---|
| src/analyze-action.ts | Retrieves and propagates checkout_path. |
| src/analyze.ts | Accepts the checkout path explicitly. |
| src/database-upload.ts | Uses propagated state and checkout path. |
| src/database-upload.test.ts | Updates calls for the refactored API. |
| src/overlay/caching.ts | Accepts checkout path explicitly. |
| src/init-action.ts | Uses state-based environment access. |
| src/setup-codeql-action.ts | Uses state-based environment access. |
| lib/entry-points.js | Generated bundle; excluded from review. |
- lib/entry-points.js
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
mbg
added this pull request to stack #4158
September 22, 2026 10:25
henrymercer
approved these changes
Sep 22, 2026
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few cherry-picked commits from the draft PR at #4148. These commits just refactor some existing logic that mainly affects the analyze action, where several places query the checkout_path input directly. The refactor here changes this so that the input is only queried once and propagated explicitly to other use sites (with the exception of in workflow.ts and git-utils.ts, which will be addressed separately in the future).
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist