Address per-language bundle review follow-ups - #4159
Merged
henrymercer merged 8 commits intoSep 22, 2026
Merged
henrymercer merged 8 commits into
henrymercer merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are behavior-neutral, with only a non-blocking wording issue noted.
Review effort: Balanced
Findings: 1
Refines tests and comments following the per-language bundle work, without changing production behavior.
Changes:
- Stubs nightly release listing directly through Octokit.
- Removes redundant test state.
- Clarifies timing and nightly eligibility comments.
| File | Description |
|---|---|
| src/util.ts | Clarifies elapsed-time documentation. |
| src/setup-codeql.test.ts | Directly stubs nightly release listing. |
| src/per-language-bundles.ts | Documents nightly version-check behavior. |
| src/per-language-bundles.test.ts | Removes redundant test setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
src/per-language-bundles.ts
Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
henrymercer
marked this pull request as ready for review
September 22, 2026 15:24
mbg
reviewed
Sep 22, 2026
Comment thread
src/per-language-bundles.ts
Outdated
Co-authored-by: Michael B. Gale <mbg@github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
mbg
approved these changes
Sep 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 22, 2026
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the remaining review feedback from #4146: stub nightly release listing directly, remove redundant test state, and clarify the timing and nightly eligibility comments. No production behavior changes.