| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Warning
Restoring inputs now fails when no persisted state exists, breaking the previous no-op behavior.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Adds contextual error messages to JSON parsing failures across action inputs, CLI output, tracer configuration, and SARIF handling.
Changes:
| File | Description |
|---|---|
| src/util.ts | Adds context to matrix parsing and object cloning errors. |
| src/tracer-config.ts | Identifies the tracing configuration file on failure. |
| src/sarif/index.ts | Identifies the SARIF file on parsing failure. |
| src/codeql.ts | Adds language and CLI output to extractor parsing errors. |
| src/actions-util.ts | Adds context when restoring persisted inputs. |
| lib/entry-points.js | Generated bundle; excluded from review by policy. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
|
The changes in this PR have already worked in helping us identify the cause for the intermittent (and rare) CI failures we previously observed that resulted in: Expected ',' or ']' after array element in JSON at position 6 (line 1 column 7) With the changes in this PR, we now get the missing context: Error: Failed to parse extractor path for 'python' from CLI: Expected ',' or ']' after array element in JSON at position 6 (line 1 column 7) Output was: [0.004s][warning][perf,memops] Cannot use file /tmp/hsperfdata_runner/5260 because it is locked by another process (errno = 11) |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR wraps a few existing JSON.parse calls in try/catch blocks in order to (essentially) re-throw errors with more context added to them about the specific JSON.parse call that failed. That can help with troubleshooting in cases where the context of the failure isn't otherwise apparent from a downstream error handler. This doesn't change any behaviour.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist