Improve job naming for the release workflow - #4169
Merged
mbg merged 6 commits intoOct 6, 2026
Merged
mbg merged 6 commits into
mbg merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The composite reusable-workflow check is not excluded as intended.
Review effort: Balanced
Findings: None
Improves release workflow job naming and excludes the resulting checks from required PR checks.
Changes:
- Names preparation, update, backport, and release-information jobs.
- Adds release job names to required-check exclusions.
| File | Review |
|---|---|
| pr-checks/excluded.yml | The composite Prepare / Release info check is not excluded by the exact-match entries and must be addressed. |
| .github/workflows/update-release-branch.yml | Names the release workflow jobs. |
| .github/workflows/rollback-release.yml | Renames the preparation job; the stale job-name comment is a non-blocking nit. |
| .github/workflows/prepare-release.yml | Renames the reusable job to Release info. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
mario-campos
previously approved these changes
Sep 24, 2026
mario-campos
previously approved these changes
Sep 30, 2026
mario-campos
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good. I found a comment that should be updated but other than that, LGTM 👍
Sorry, something went wrong.
Comment thread
.github/workflows/rollback-release.yml
Outdated
mario-campos
approved these changes
Oct 6, 2026
mario-campos
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks, LGTM
Sorry, something went wrong.
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the jobs are not currently named and we end up with Prepare release / Prepare release for the prepare-release.yml workflow call. This PR adds names for the two unnamed jobs, disambiguates Prepare release, and adds all to the excluded.yml config for required checks. The previous release jobs weren't all in there and it's unlikely that they'd need to be since we wouldn't normally expect that workflow to run on PRs, but I added them there for completeness. I left the old ones for now since we can always remove them later if needed.