| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
The workflow now safely continues for lib-only conflicts while rejecting conflicts elsewhere.
Review effort: Balanced
Findings: None
Fixes rebuild workflow handling for merge conflicts limited to generated lib files.
Changes:
| File | Description |
|---|---|
| .github/workflows/rebuild.yml | Corrects merge failure handling and conflict-path detection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Generally makes sense to me and it's a low risk / dev-only change in any case, so we can iterate on it if we find something doesn't quite work.
Ideally, we'd also start moving away from shell for these things and have TS-based scripts in pr-checks for this (which would have avoided the two bugs I think), but not something we should do here as part of this PR obviously.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
The rebuild workflow is meant to continue when merging the base branch only conflicts in lib, since rebuilding regenerates it. Since #3568, any conflict has failed the merge step instead, for example in this run. Steps run with bash -e, so a conflicting git merge ended the step before its exit code was recorded. The step now runs git merge as an if condition, which -e doesn't apply to, and continues only if MERGE_HEAD shows the merge is still in progress.
Fixing that alone would have exposed a second bug: under pipefail, the check for conflicts outside lib never triggered, because git diff --check exits non-zero whenever it finds a conflict marker, including in lib. The check now lists unmerged paths with git diff --name-only --diff-filter=U, which also catches conflicts without markers, such as modify/delete conflicts.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist