| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Warning
The backend-compatibility behavior lacks regression assertions in the existing unit tests.
4 open findingsAdds primary cache keys to restore-key lists for compatibility with third-party cache backends that only prefix-match restore keys.
Changes:
| File | Description |
|---|---|
| src/trap-caching.ts | Adds the preferred key to restore keys. |
| src/dependency-caching.ts | Adds the primary dependency key to restore keys. |
| src/overlay/status.ts | Adds the status key to restore keys. |
| src/overlay/caching.ts | Fixes overlay-base restoration on affected backends. |
| lib/entry-points.js | Excluded generated file; not reviewed. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
|
I won't extend test coverage for this change as Copilot requested, since it concerns a third-party behaviour. The existing tests model the correct behaviour and as long as they continue to pass with this change, I am happy. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
See #4202 for context. Apparently some third-party systems don't use the primary cache key that's used for cache restores as a restore key if it's not also included separately as a restore key. This PR changes our restoreCache calls so that the primary restore key is also always included as a restore key. This should not make a difference on first-party systems.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
Third-party runner environments.
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist