FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add CHANGELOG.md modification check and warning comment by mario-campos · Pull Request #4217 · github/codeql-action · GitHub

  1. github
  2. codeql-action

Repository navigation

Add CHANGELOG.md modification check and warning comment #4217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mario-campos wants to merge 50 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
+649 −2
Conversation 80 Commits 50 Checks 229 Files changed 5
Open

Add CHANGELOG.md modification check and warning comment #4217

Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
b2b77a8
Add CHANGELOG.md modification check and warning comment
mario-campos Oct 8, 2026
fbd33ac
Gate comment-post step on successful fetch-base
mario-campos Oct 8, 2026
43ac64c
Use `gh api` instead of third-party Action
mario-campos Oct 8, 2026
f7aa9dc
Move post-comment step to `post-pr-comments` job
mario-campos Oct 8, 2026
780e947
Skip CHANGELOG.md modification warning for release and backport PRs
mario-campos Oct 8, 2026
ae75d46
Exclude "Mergeback" and "Update default bundle" PRs from CHANGELOG.md…
mario-campos Oct 8, 2026
6e4d3fb
Use a sticky comment to warn about CHANGELOG.md changes
mario-campos Oct 8, 2026
d97a656
Update CHANGELOG.md warning message to reference change-notes directory
mario-campos Oct 8, 2026
ccdf690
Escape backticks PR comment body
mario-campos Oct 8, 2026
928548a
Refine exclusion conditions for CHANGELOG-modification comment
mario-campos Oct 8, 2026
0707124
Delete CHANGELOG.md-modification comment if CHANGELOG.md no longer mo…
mario-campos Oct 8, 2026
27d37d9
Format all file references as inline Markdown code spans
mario-campos Oct 8, 2026
9fe741e
Simplify `if` condition of CHANGELOG-comment-post step
mario-campos Oct 8, 2026
8c8b082
Add script and Action for managing PR comments
mario-campos Oct 9, 2026
14cefaa
Replace bash/run step with local Action `post-comment`
mario-campos Oct 9, 2026
4d464b0
Improve issue ID parsing and validation logic
mario-campos Oct 9, 2026
3c452a1
Use HTTP link to `unreleased-change-notes/README.md`
mario-campos Oct 9, 2026
f1419b8
Reject empty `--marker`
mario-campos Oct 9, 2026
e7dadca
Refactor comment handling logic into `performAction` for improved tes…
mario-campos Oct 9, 2026
ae9f97b
Make post-comment marker configurable
mario-campos Oct 28, 2026
90d1bc9
Remove bespoke post-comment argument validation
mario-campos Oct 28, 2026
ae23865
Move comment branching into workflow steps
mario-campos Oct 28, 2026
9448877
Simplify post-comment to a single set-comment mode
mario-campos Oct 28, 2026
03137fc
Rename changelog outputs to modified
mario-campos Oct 28, 2026
36f220a
Remove unused post-comment step IDs
mario-campos Oct 28, 2026
c069d49
Test sticky comments using observable state
mario-campos Oct 28, 2026
afaf324
Move `resolveToken` to `pr-checks/api-client.ts`
mario-campos Oct 29, 2026
3fb676f
Use existing `RepositoryNwo` type
mario-campos Oct 29, 2026
56fa196
Use YAML multiline string for the Action's inputs' descriptions
mario-campos Oct 29, 2026
2902eea
Checkout `main` instead of PR's base for the `post-pr-comments` job
mario-campos Oct 29, 2026
87cac24
Avoid sparse checkout
mario-campos Oct 29, 2026
5bb3554
Make input-validation assertions more granular
mario-campos Oct 29, 2026
f13bcf3
Warn if more than one marked comment was found
mario-campos Oct 29, 2026
19e1ab5
Update `pr-checks/post-comment.ts` description comment
mario-campos Oct 29, 2026
9359b6b
Wrap `--marker` argument in HTML comment tags automatically
mario-campos Oct 29, 2026
e965148
Avoid non-null assertion operators by asserting arguments
mario-campos Oct 29, 2026
94f0998
Avoid creating resolved comments without an existing warning
mario-campos Oct 29, 2026
1304cc4
Potential fix for pull request finding 'CodeQL / Missing space in str…
mario-campos Oct 29, 2026
68a9dcb
Prefer `== true` over `!= false`
mario-campos Oct 30, 2026
1a18e90
Merge branch 'main' into mario-campos/warn-on-changelog-write
mario-campos Oct 30, 2026
a587867
Update `actions/setup-node` action to version 7.1.0
mario-campos Oct 30, 2026
0bc39f9
Prefer last comment when there are multiple to choose from
mario-campos Oct 30, 2026
b25bc2e
Change `RepositoryNwo` import to `type`
mario-campos Oct 30, 2026
8ba2b06
Use `parseRepositoryNwo` instead of splitting manually
mario-campos Oct 30, 2026
eec6442
Make precedence explicit with parens
mario-campos Oct 30, 2026
97a381d
Split long line
mario-campos Oct 30, 2026
9de5eac
Make error a bit clearer and more actionable
mario-campos Oct 30, 2026
d715939
Replace `--create-if-missing` to `--update-only`
mario-campos Oct 30, 2026
4094755
Polish `post-comment.ts` usage comment
mario-campos Nov 2, 2026
9d1378f
Use new `case` expression for evaluating conditional `--update-only` …
mario-campos Nov 2, 2026
File filter

Filter by extension

Filter by extension .yml  (1) All 1 file type selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Next Next commit
Update CHANGELOG.md warning message to reference change-notes directory
  • Loading branch information
mario-campos committed Oct 8, 2026
commit d97a656f70b91aaa5380a8bf2278eed24c0b6b18
8 changes: 4 additions & 4 deletions .github/workflows/pr-checks.yml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@ jobs:
fi

body="$COMMENT_MARKER
⚠️ CHANGELOG.md was modified in this PR. Please do not modify CHANGELOG.md directly.
Instead, describe your change as a change-note. The CHANGELOG.md file will be automatically
generated from change-notes. For more information,
see [CONTRIBUTING.md](https://github.com/github/codeql-action/blob/main/CONTRIBUTING.md)."
⚠️ CHANGELOG.md has been modified in this PR. Please do not modify CHANGELOG.md directly.
Instead, create a change-note file in `unreleased-change-notes/`. The CHANGELOG.md
Comment thread
Copilot marked this conversation as resolved.
Resolved
file will be automatically generated from those change-notes.
See [unreleased-change-notes/README.md](unreleased-change-notes/README.md) for more information."
gh api --method POST "repos/$GITHUB_REPOSITORY/issues/$PR_NUMBER/comments" --field body="$body"
Loading
Back | FazBrowse Home | New Git URL