Do not validate change-note file names or frontmatter - #4218
Merged
mario-campos merged 2 commits intoOct 9, 2026
Merged
mario-campos merged 2 commits into
mario-campos merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Presently, the strict filename or frontmatter are not being used; so we're validating them unnecessarily. So, for now, remove these checks until we decide to either do something with them, or delete the code entirely.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Regression tests are needed to verify that unconventional filenames and frontmatter are accepted.
1 open finding What changed in this PRDisables filename and frontmatter-category checks while retaining Markdown content validation.
Changes:
- Removes filename and category validation from file-level checks.
- Removes tests expecting those checks to fail.
| File | Description |
|---|---|
| pr-checks/changelog/validate.ts | Limits validation to Markdown content. |
| pr-checks/changelog/validate.test.ts | Removes outdated rejection tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
pr-checks/changelog/validate.test.ts
mbg
previously approved these changes
Oct 9, 2026
mbg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks. I'd ignore Copilot's request for tests. This doesn't need any.
Sorry, something went wrong.
Comment thread
pr-checks/changelog/validate.test.ts
mbg
approved these changes
Oct 9, 2026
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #4211, @mbg noted that the strict validation is unnecessary. Nothing about the Action relies on the change-note file names to be a certain format. And the category in the frontmatter is validated, but never used.
This PR effectively disables those checks from pr-checks/changenotes.ts validate while keeping the core of the code until we can decide to either completely remove it or apply it.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist