| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Dependabot workflow re-runs may attempt to post comments using a read-only token.
1 open finding What changed in this PRUpdates PR-check workflow triggers and repository-size comment conditions.
Changes:
| File | Description |
|---|---|
| .github/workflows/pr-checks.yml | Adjusts triggers and job conditions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
| branches: | ||
| - "main" | ||
| - "releases/v*" |
There was a problem hiding this comment.
Having this trigger on all pushes is useful for catching problems where folks edit a TS file and push it to a branch to do some testing, but forget to compile the Action. This failing check is then be a useful indicator to help resolve why their intended behaviour wasn't occurring.
Sorry, something went wrong.
There was a problem hiding this comment.
That seems like a very niche use case that comes at the cost of a lot of extra runs and confusion. For testing, I'd suggest opening a draft PR that triggers the checks instead of relying on push triggers.
If you feel strongly that this is a useful behaviour though, then I'd suggest we split out the relevant checks from this workflow (possibly as a reusable workflow) that is called by a workflow with a different name that runs on push and this one.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR makes two changes to pr-checks.yml:
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist