FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable cleaning up toolcache bundles by default by henrymercer · Pull Request #4242 · github/codeql-action · GitHub

Repository navigation

Enable cleaning up toolcache bundles by default - #4242

Merged
henrymercer merged 2 commits into
mainfrom
henrymercer/graduate-toolcache-cleanup
Oct 16, 2026
Merged

henrymercer merged 2 commits into
mainfrom
henrymercer/graduate-toolcache-cleanup

Conversation

Copy link
Copy Markdown
Contributor

This PR graduates the cleanup_toolcache_bundles feature flag and removes the CODEQL_ACTION_CLEANUP_TOOLCACHE_BUNDLES override.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - The existing codeql-action/toolcache-bundle-cleanup diagnostic reports deleted versions and whether cleanup failed.
  • Other - Cleanup failures remain visible in action logs and do not prevent the bundle download from continuing.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows. The removed environment variable was an internal rollout override rather than a documented workflow interface.
  • Consider adding a changelog entry for this change. The 4.38.0 entry already describes the staged rollout, so no additional entry is included.
  • Confirm the readme and docs have been updated if necessary. No documentation updates are required.

henrymercer and others added 2 commits October 15, 2026 14:54
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9bf883d4-ecd7-4428-970f-86895f760571
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9bf883d4-ecd7-4428-970f-86895f760571
Copilot AI max review requested due to automatic review settings October 15, 2026 19:44
github-actions Bot added the size/S Should be easy to review label Oct 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

🔵 Needs a closer look

Removing the cleanup disable switch warrants human confirmation of rollout telemetry.

0 open findings

What changed in this PR

Makes CodeQL toolcache cleanup the default on eligible GitHub-hosted runners to reclaim disk space for analysis.

Changes:

  • Removes the cleanup feature flag and environment override while retaining existing safeguards.
  • Updates tests and the multi-language autodetection check template for the new default.
File Description
src/​setup-codeql.ts Removes feature gating from bundle cleanup.
src/​setup-codeql.test.ts Updates cleanup tests and injected environments.
src/​feature-flags.ts Removes the cleanup flag and override configuration.
pr-checks/​checks/​multi-language-autodetect.yml Removes the obsolete cleanup override.
Files excluded by content exclusion policy (2)
  • .github/workflows/__multi-language-autodetect.yml
  • lib/entry-points.js

🧠 Review effort: Max


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

henrymercer marked this pull request as ready for review October 15, 2026 20:02
henrymercer requested a review from a team as a code owner October 15, 2026 20:02
henrymercer added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit ae098fa Oct 16, 2026
235 checks passed
henrymercer deleted the henrymercer/graduate-toolcache-cleanup branch October 16, 2026 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Should be easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL