Add Copilot instructions for FFs, and update documentation more generally - #4247
Merged
mbg merged 6 commits intoOct 16, 2026
Merged
mbg merged 6 commits into
mbg merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Remaining suggestions concern non-blocking documentation clarity and wording.
2 open findingsAlign request prohibition with suggested examples · New
Clarifies CodeQL Action guidance for review feedback and release notes.
Changes:
- Expands guidance on review priorities and constructive wording.
- Documents change-note expectations for feature flags and workflow-impacting changes.
| File | Description |
|---|---|
| unreleased-change-notes/README.md | Adds guidance on which changes need release notes. |
| .github/copilot-instructions.md | Expands review guidance and adds feature-flag documentation rules. |
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
.github/copilot-instructions.md
Outdated
Comment thread
.github/copilot-instructions.md
Outdated
henrymercer
previously approved these changes
Oct 16, 2026
Comment thread
.github/copilot-instructions.md
Outdated
henrymercer
approved these changes
Oct 16, 2026
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by #4244 (comment). I added a few other improvements based on recent experiences as well.