Move inline script from diagnostics-export.yml to a .ts file - #4248
mbg merged 1 commit into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
🟢 Approval recommended
The development-only extraction preserves existing checks and has no blocking issues.
0 open findings
What changed in this PRExtracts the diagnostics-export workflow’s inline checks into TypeScript, preparing the development-only test for #4223.
Changes:
- Moves existing SARIF assertions into a standalone script with explicit missing-field checks.
- Enables Node setup and runs the script with tsx.
| File | Description |
|---|---|
| pr-checks/checks/diagnostics-export.yml | Replaces the inline script with TypeScript execution. |
| pr-checks/check-diagnostics.ts | Contains the extracted diagnostic assertions. |
- .github/workflows/__diagnostics-export.yml
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
There was a problem hiding this comment.
Now that this lives separately from the check, we could add a brief description of what this script does in a header docstring.
Sorry, something went wrong.
There was a problem hiding this comment.
Makes sense, will do as a follow-up somewhere else.
Sorry, something went wrong.
A simple dev-only change in prep for #4223 which moves the inline script out of the diagnostics-export.yml workflow and into a TS file, along with some minor changes to make TS happy.