Use runInActions/ActionState for all actions - #4254
Open
mbg wants to merge 16 commits into
Open
mbg wants to merge 16 commits into
mbg wants to merge 16 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mbg
force-pushed
the
mbg/all-action-state
branch
from
fdc373d to
7a6a2ca
Compare
October 19, 2026 20:59
mbg
force-pushed
the
mbg/all-action-state
branch
from
7a6a2ca to
00434f0
Compare
October 21, 2026 15:50
mbg
marked this pull request as ready for review
October 21, 2026 15:52
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Centralized input restoration overwrites the runtime cancellation status, causing cancelled analyses to cache an unnecessary failure.
3 open issuesRestoring inputs overwrites runtime INPUT_JOB-STATUS · New
- lib/entry-points.js: Excluded by your content exclusion settings
Standardizes CodeQL action entry points around runInActions and ActionState for consistent execution and shared state access.
Changes:
- Centralizes post-action input restoration.
- Extends action-state APIs and test helpers.
- Standardizes action display names and failure messages.
| File | Description |
|---|---|
| src/upload-sarif-action-post.ts | Adopts the shared runner and action state. |
| src/testing-utils.ts | Adds failure tracking and state access for tests. |
| src/status-report.ts | Adds post-action identifiers and consistent display names. |
| src/start-proxy-action-post.ts | Moves proxy cleanup into the shared runner. |
| src/resolve-environment-action.ts | Uses action state for inputs and reporting. |
| src/init-action-post.ts | Adopts centralized restoration and state-based APIs. |
| src/analyze-action-post.ts | Adopts the shared runner and environment access. |
| src/actions-util.ts | Extends action APIs and refactors input restoration. |
| src/action-common.ts | Restores post-action inputs before execution. |
| src/action-common.test.ts | Updates display-name and failure-message assertions. |
Review effort: Max
Sorry, something went wrong.
Comment thread
src/actions-util.ts
|
|
||
| for (const [name, value] of persistedInputs) { | ||
| process.env[name] = value; | ||
| action.env.set(name, value); |
Comment thread
src/start-proxy-action-post.ts
|
|
||
| /** The main entry point for the `start-proxy` post-action. */ | ||
| export async function runWrapper() { | ||
| await runInActions(startProxyPostAction); |
Comment thread
src/status-report.ts
Resolved
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily a refactor which updates all of our actions (and post-actions) to use runInActions and, by extension, ActionState. That ensures consistency across the different actions and means we can take advantage of ActionState in their respective call trees going forward.
This PR also makes minimal changes to the entry points to start make use of ActionState there.
I have also made the Action display names that are reported in unhandled error messages when they are logged more consistent.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist