Add toolcache.ts script for bundle(-from)-toolcache checks - #4255
Merged
mbg merged 8 commits intoOct 22, 2026
Merged
mbg merged 8 commits into
mbg merged 8 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mbg
force-pushed
the
mbg/npm-versions
branch
2 times, most recently
from
dbc9fda to
a4f6fc0
Compare
October 20, 2026 13:18
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The expected-count assertion can report success when fewer CodeQL versions are cached than requested.
1 open issue 2 files not reviewed- .github/workflows/__bundle-from-toolcache.yml: Excluded by your content exclusion settings
- .github/workflows/__bundle-toolcache.yml: Excluded by your content exclusion settings
Consolidates toolcache PR checks into a shared TypeScript utility using locked workspace dependencies.
Changes:
- Adds commands to clear and inspect cached CodeQL versions.
- Updates both check templates to invoke the utility.
- Declares the tool-cache dependency in the workspace and lockfile.
| File | Description |
|---|---|
| pr-checks/toolcache.ts | Adds shared toolcache commands. |
| pr-checks/package.json | Declares the tool-cache dependency. |
| pr-checks/checks/bundle-toolcache.yml | Uses the utility to clear and verify the cache. |
| pr-checks/checks/bundle-from-toolcache.yml | Uses the utility to verify cached installations. |
| package-lock.json | Records the workspace dependency. |
Review effort: Max
Sorry, something went wrong.
Comment thread
pr-checks/toolcache.ts
Resolved
henrymercer
previously approved these changes
Oct 21, 2026
Comment thread
pr-checks/toolcache.ts
Resolved
Comment thread
pr-checks/toolcache.ts
Resolved
Comment thread
pr-checks/toolcache.ts
Resolved
henrymercer
approved these changes
Oct 22, 2026
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the script to be shared between the two workflows and ensures that we don't have a floating npm install step in these workflows.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist