Fix race condition with actions/checkout@v1 - #428
Merged
simon-engledew merged 3 commits intoMar 23, 2021
Merged
simon-engledew merged 3 commits into
simon-engledew merged 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
simon-engledew
force-pushed
the
simon-engledew/detect-merge
branch
3 times, most recently
from
69dbd1b to
4c8a765
Compare
March 22, 2021 11:40
simon-engledew
force-pushed
the
simon-engledew/detect-merge
branch
from
4c8a765 to
b0ed899
Compare
March 22, 2021 12:01
…l a merge Work around a race condition in actions where sometimes GITHUB_SHA != git rev-parse head
simon-engledew
force-pushed
the
simon-engledew/detect-merge
branch
from
b0ed899 to
ef92c5a
Compare
March 22, 2021 12:05
simon-engledew
marked this pull request as ready for review
March 22, 2021 12:43
rneatherway
reviewed
Mar 22, 2021
Comment thread
src/actions-util.ts
Outdated
Comment thread
src/actions-util.ts
Outdated
Comment thread
src/actions-util.ts
rneatherway
approved these changes
Mar 22, 2021
rneatherway
approved these changes
Mar 22, 2021
simon-engledew
pushed a commit
that referenced
this pull request
Mar 25, 2021
Fixes the rev-parse issues caused by #428
Merged
Merged
aofaof0907
pushed a commit
to aofaof0907/codeql-action
that referenced
this pull request
Jul 29, 2021
Fixes the rev-parse issues caused by github#428
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work around a race condition in Actions where sometimes GITHUB_SHA != git rev-parse head after an actions/checkout@v1
This leads to the upload incorrectly rewriting the ref, causing analyses to go missing. 😭
Do not rewrite the ref when we: