Dispatch fingerprint callbacks only to matching source lines - #4295
Open
dsyme wants to merge 1 commit into
Open
dsyme wants to merge 1 commit into
dsyme wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the SARIF fingerprint dispatch optimization.
No open issues 🎉
1 file not reviewed- lib/entry-points.js: Excluded by your content exclusion settings
Optimizes SARIF fingerprint generation by dispatching each source-line hash only to matching results, while preserving the existing hash algorithm and fingerprint behavior.
Changes:
- Indexes callbacks by line within each file, avoiding per-line iteration over every result.
- Adds regression coverage for duplicate locations, different lines, out-of-range locations, and preservation of inconsistent existing fingerprints with warnings.
- Adds a changenote describing the performance improvement.
| File | Description |
|---|---|
| unreleased-change-notes/fingerprint-callback-dispatch.md | Documents faster fingerprint generation without changing fingerprints. |
| src/fingerprints.ts | Groups callbacks by source line for targeted dispatch. |
| src/fingerprints.test.ts | Tests matching-line dispatch and preserved edge-case behavior. |
Review effort: Balanced (auto)
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Index fingerprint callbacks by source line within each file instead of invoking every result callback for every emitted line hash. Files are still hashed once and the rolling hash and fingerprint format are unchanged.
This removes the lines-times-results callback dispatch cost on files with many findings, including the repeated Object.values array creation. Multiple results on the same line still receive the same fingerprint; inconsistent existing fingerprints are preserved and still generate warnings.
Validation
Validated locally with Node 24.22.2. This PR makes no whole-analysis or fleet savings claim.