FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove `macos-14-xlarge` from `codeql` workflow by henrymercer · Pull Request #4309 · github/codeql-action · GitHub

Repository navigation

Remove macos-14-xlarge from codeql workflow - #4309

Merged
henrymercer merged 1 commit into
mainfrom
henrymercer/replace-macos-14-xlarge-runner
Nov 9, 2026
Merged

henrymercer merged 1 commit into
mainfrom
henrymercer/replace-macos-14-xlarge-runner

Conversation

Copy link
Copy Markdown
Contributor

The analyze-javascript (macos-14-xlarge) jobs in the codeql workflow are now cancelled with "The configuration 'macos-14-arm64-us-xl' is not supported". These are required checks, so every PR in the merge queue is failing. This PR removes macos-14-xlarge without a replacement, since many other PR checks already run on macOS 26. A follow-up PR will look at the overall PR check coverage across runner images.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - CI failures.

Are there any special considerations for merging or releasing this change?

  • Special considerations - This PR removes two required checks, so the required checks need to be updated with pr-checks/sync-checks.ts before it can merge. The release branches will pick up the workflow change in the next release, as they did for Remove macos-13 from codeql workflow #3274.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
henrymercer requested a review from a team as a code owner November 6, 2026 18:20
Copilot AI dynamic review requested due to automatic review settings November 6, 2026 18:20
github-actions Bot added the size/XS Should be very easy to review label Nov 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🔵 Needs a closer look

Although the workflow diff is straightforward, safe merging requires removing both macos-14 matrix contexts from external branch-protection required checks, which cannot be verified from the checked-in files.

No open issues 🎉

What changed in this PR

Removes the unsupported macos-14-xlarge runner from the CodeQL JavaScript analysis matrix, preventing required merge-queue checks from failing.

Changes:

  • Removes macos-14-xlarge from the analyze-javascript operating-system matrix.
  • Retains Ubuntu, Windows, and macos-15-xlarge coverage.
  • Required-check configuration must be synchronized separately.
File Description
.github/​workflows/​codeql.yml Removes the unsupported macOS 14 runner from the CodeQL analysis matrix.

Review effort: Lite (auto)

jketema commented Nov 9, 2026

Copy link
Copy Markdown

Should we add macos-26?

henrymercer commented Nov 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Should we add macos-26?

I plan to rework the checks so we make sure each runner image is tested, but not necessarily on the JS analysis for this repo. I'll do that in a separate PR though so we can unblock CI faster.

(Note for instance that Swift analysis on macos-26 is already covered by this check: https://github.com/github/codeql-action/actions/runs/42269788821/job/128071063024?pr=4309)

henrymercer added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit e4ce43d Nov 9, 2026
229 checks passed
henrymercer deleted the henrymercer/replace-macos-14-xlarge-runner branch November 9, 2026 12:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL