Add external git repositories to search path for custom queries - #440
Merged
edoardopirovano merged 1 commit intoApr 21, 2021
Merged
edoardopirovano merged 1 commit into
edoardopirovano merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
edoardopirovano
force-pushed
the
add-search-path
branch
2 times, most recently
from
9e8e6ab to
1319b59
Compare
April 7, 2021 15:40
aeisenberg
reviewed
Apr 20, 2021
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry, this slipped through the cracks. Reviewed now. I don't think we can be changing the format of the config file.
Sorry, something went wrong.
aeisenberg
reviewed
Apr 20, 2021
Comment thread
src/analyze.ts
aeisenberg
approved these changes
Apr 21, 2021
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good now that I understand it all.
Sorry, something went wrong.
Comment thread
src/config-utils.ts
edoardopirovano
force-pushed
the
add-search-path
branch
from
fbb2150 to
7a08bb4
Compare
April 21, 2021 16:29
Copy link
Copy Markdown
Contributor
Author
|
Pushed a rebase to fix conflict, will merge once tests pass. |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a query from an external repository, we may need some additional dependencies that are specified in this repository. To find these, we should add the the root of the external repository to the search path in our CLI invocations. At the moment, this is done in resolve queries but not in database analyze. This PR adds the search path in the latter call. As a result of this, we may perform multiple database analyze invocations (one for each external repository, with the respective search path in each one) and have to merge the SARIF results into one file in order to not break consumers who are expecting all custom query results to be in a single file.