Fixes a regex for language and locale recognition - #442
Merged
aeisenberg merged 2 commits intoApr 14, 2021
Merged
aeisenberg merged 2 commits into
aeisenberg merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
See oasis-tcs/sarif-spec#490 See #418 Note that this changes the sarif spec file. Unless this change is actually merged in the sarif spec repo, the version used by the action will be slightly different.
chrisgavin
approved these changes
Apr 9, 2021
chrisgavin
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Awesome! Thank you very much! Hopefully the fix gets merged upstream too, but it makes sense to me to fix it here.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See oasis-tcs/sarif-spec#490
See #418
Note that this changes the sarif spec file. Unless this
change is actually merged in the sarif spec repo, the
version used by the action will be slightly different.
Merge / deployment checklist