Use externalRepoAuth when getting a remote config - #443
Merged
aeisenberg merged 1 commit intoApr 9, 2021
Merged
aeisenberg merged 1 commit into
aeisenberg merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This allows users to specify a different token for retrieving the codeql config from a different repository. Fixes github/advanced-security-field#185
adityasharad
approved these changes
Apr 9, 2021
adityasharad
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, thanks for the quick fix.
I see we were already passing around aGitHubApiExternalRepoDetails to check out query repos configured in the workflow file, so that case is already correct.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
That's right. It's handled. |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to specify a different token for retrieving the
codeql config from a different repository.
Merge / deployment checklist