Restrict Actions token permissions in CodeQL workflow. - #457
Merged
chrisgavin merged 4 commits intoApr 30, 2021
Merged
chrisgavin merged 4 commits into
chrisgavin merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
chrisgavin
force-pushed
the
restrict-permissions
branch
from
d4fd699 to
7e85b5d
Compare
April 22, 2021 16:07
chrisgavin
marked this pull request as ready for review
April 22, 2021 16:16
adityasharad
approved these changes
Apr 22, 2021
…d for runs that are not from pull requests.
Copy link
Copy Markdown
Contributor
Author
|
It turns out that while this is probably still useful, it was actually passing with less permissions than it should have. This was for two reasons:
I feel like we can probably still test whether the required permissions have changed, but it will involve having to test changes against a private repository which is a bit of a pain. I'll merge this anyway because it seems like it's good practice to start being more explicit about what permissions we require. |
Sorry, something went wrong.
Merged
This was referenced Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This both helps improve the security of the workflow and ensures we don't accidentally add a dependency on any new permissions without realizing.
Merge / deployment checklist