Change from metric to rule - #474
Merged
aeisenberg merged 1 commit intoMay 4, 2021
Merged
aeisenberg merged 1 commit into
aeisenberg merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
henrymercer
reviewed
May 4, 2021
Comment thread
src/analyze.ts
Outdated
The SARIF that we are interpreting has moved away from using `metric` to the more general term, `rule`. We need to adapt our baseline lines of code counting to use `rule` as well.
aeisenberg
force-pushed
the
aeisenberg/change-metric-id
branch
from
32b6b80 to
a2312a0
Compare
May 4, 2021 17:06
henrymercer
approved these changes
May 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SARIF that we are interpreting has moved away from using metric
to the more general term, rule. We need to adapt our baseline lines of
code counting to use rule as well.
Merge / deployment checklist