FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clarify the missing baseline lines of code warning message by aeisenberg · Pull Request #475 · github/codeql-action · GitHub

/ codeql-action Public

Clarify the missing baseline lines of code warning message - #475

Merged
aeisenberg merged 2 commits into
mainfrom
aeisenberg/warning-message
May 5, 2021
ConversationCommits (2)ChecksFiles changed
Merged

Clarify the missing baseline lines of code warning message#475
aeisenberg merged 2 commits into
mainfrom
aeisenberg/warning-message

Conversation

aeisenberg commented May 5, 2021

Copy link
Copy Markdown
Contributor

See github/codeql#5838

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

henrymercer reviewed May 5, 2021
View reviewed changes
Comment thread src/count-loc.ts Outdated
Comment thread src/count-loc.ts Outdated
Comment thread src/count-loc.ts Outdated
aeisenberg force-pushed the aeisenberg/warning-message branch 2 times, most recently from 18e4667 to 9228317 Compare May 5, 2021 15:46
henrymercer approved these changes May 5, 2021
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Couple more suggestions on the message

Comment thread src/count-loc.ts Outdated
Comment thread src/count-loc.ts Outdated
Comment thread src/count-loc.ts Outdated
Comment thread src/count-loc.ts Outdated

aeisenberg commented May 5, 2021

Copy link
Copy Markdown
Contributor Author

All good suggestions.

aeisenberg force-pushed the aeisenberg/warning-message branch from 9228317 to faa2564 Compare May 5, 2021 15:55

adityasharad commented May 5, 2021

Copy link
Copy Markdown
Contributor

Do you want to keep this at the warning level (which makes it visible in the Actions summary page), or drop it down to info/debug so it's only present in the logs view?

aeisenberg commented May 5, 2021

Copy link
Copy Markdown
Contributor Author

Hmmm...didn't realize that this would be raised to being visible in the summary page. This is a good point. I'll drop down its verbosity.

aeisenberg commented May 5, 2021

Copy link
Copy Markdown
Contributor Author

A debug message won't appear at all unless the debug flag is set to true. I'd be leaning towards using an info message.

aeisenberg force-pushed the aeisenberg/warning-message branch from faa2564 to e04c62b Compare May 5, 2021 16:30
aeisenberg merged commit 5321045 into main May 5, 2021
aeisenberg deleted the aeisenberg/warning-message branch May 5, 2021 18:20
github-actions Bot mentioned this pull request May 10, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

adityasharad adityasharad approved these changes
henrymercer henrymercer approved these changes

Assignees

henrymercer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL