Change include path for lines of code counting - #500
Merged
aeisenberg merged 1 commit intoMay 13, 2021
Merged
aeisenberg merged 1 commit into
aeisenberg merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
adityasharad
approved these changes
May 13, 2021
adityasharad
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks reasonable, look out for conflicts with the other LOC PR.
Sorry, something went wrong.
Comment thread
src/count-loc.test.ts
Comment on lines
+71
to
+72
| // note that "**" is always included. The includes are for extra | ||
| // directories outside the normal structure. |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Outdated comment?
Sorry, something went wrong.
Comment thread
src/count-loc.test.ts
Outdated
|
|
||
| t.deepEqual(results, { | ||
| js: 15, | ||
| js: 12, |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Might conflict with your other PR.
Sorry, something went wrong.
Previously, we were always using `**` in the include path. the effect of this was to always count lines in the entire repository unless explicitly added to the paths-ignore. This was incorrect behaviour. Now we only using `**` if the include path is otherwise empty.
aeisenberg
force-pushed
the
aeisenberg/paths-include
branch
from
96b869f to
8e61fc2
Compare
May 13, 2021 19:05
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were always using ** in the include path. the
effect of this was to always count lines in the entire
repository unless explicitly added to the paths-ignore. This
was incorrect behaviour. Now we only using ** if the include
path is otherwise empty.
Merge / deployment checklist