Use the prefix id for keying into metrics rules - #502
Merged
aeisenberg merged 2 commits intoMay 13, 2021
Merged
aeisenberg merged 2 commits into
aeisenberg merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
adityasharad
approved these changes
May 13, 2021
adityasharad
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good catch.
Sorry, something went wrong.
Fixes a bug where we were looking for incorrect keys for metrics rules. Previously, we were using full language names in the keys. Now, we use the short language names in the metric ids. This is done through a simplification of the code. Also, this change does two smaller things: 1. Prints out the baseline count to the logs 2. Adds the `assertNever` function to ensure we never miss a case in a switch statement. This function is borrowed from vscode-codeql.
aeisenberg
force-pushed
the
aeisenberg/metric-id
branch
from
2b3d0c1 to
e8b2a98
Compare
May 13, 2021 18:11
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the quick review @adityasharad, but I decided to make a change. I think this simplifies things a bit. Could you take another look? |
Sorry, something went wrong.
adityasharad
approved these changes
May 13, 2021
adityasharad
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Makes sense. We use the Language entity wherever possible, and convert only at the points where the ID prefix or Linguist name is needed.
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where we were looking for incorrect keys for metrics rules.
Previously, we were using full language names in the keys. Now, we use
the short language names in the metric ids. This is done through a
simplification of the code.
Also, this change does two smaller things:
a switch statement. This function is borrowed from vscode-codeql.### Merge / deployment checklist