Add warnings about CLI hack to codeql.ts - #503
Merged
hmakholm merged 1 commit intoMay 14, 2021
Merged
hmakholm merged 1 commit into
hmakholm merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
reviewed
May 14, 2021
Comment thread
src/codeql.ts
Outdated
| // configurations. Consequently the name must not be changed. | ||
| // (This warning can be removed once a different way to recognize the | ||
| // action/runner has been implemented in `codeql database trace-command` | ||
| // _and_ is present in the lastest CLI release.) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
And above...
Suggested change
| // _and_ is present in the lastest CLI release.) | |
| // _and_ is present in the lastest support CLI release.) |
Sorry, something went wrong.
hmakholm
force-pushed
the
hmakholm/pr/warn-magic-names
branch
from
62a82f2 to
dafbcbf
Compare
May 14, 2021 19:22
These warnings refer to a hack that was added to the CLI in https://github.com/github/semmle-code/pull/39335 They can be removed again once the CLI has a more principled way for the CLI to recognize that it's being invoked by the runner/action.
hmakholm
force-pushed
the
hmakholm/pr/warn-magic-names
branch
from
dafbcbf to
e7d4215
Compare
May 14, 2021 19:23
aeisenberg
approved these changes
May 14, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These warnings refer to a hack that was added to the CLI in https://github.com/github/semmle-code/pull/39335
They can be removed again once the CLI has a more principled way for the CLI to recognize that it's being invoked by the runner/action.