Add Ruby as a possible language - #513
aibaars merged 5 commits into
Conversation
Sorry, something went wrong.
| }, | ||
| }).exec(); | ||
|
|
||
| return JSON.parse(output); |
There was a problem hiding this comment.
Catch malformed json errors and rethrow with a meaningful message.
| return JSON.parse(output); | |
| try { | |
| return JSON.parse(output); | |
| } catch (e) { | |
| throw new Error("Something meaningful.); | |
| } |
Sorry, something went wrong.
There was a problem hiding this comment.
Wouldn't that suppress the likely interesting error message of e ? In Java I'd write new Error("Unexpected output from codeql resolve languages", e) . What would be the equivalent in Javascript?
Sorry, something went wrong.
There was a problem hiding this comment.
I think just construct the message as a string. So like new Error("Unexpected output from codeql resolve languages: " + e.message) and maybe some type checks to make sure that e.message exists.
Sorry, something went wrong.
There was a problem hiding this comment.
I opted to just write Unexpected output from codeql resolve languages: ${e} . This should include the original error's type and side-steps the problem of a potentially empty message string.
Sorry, something went wrong.
aeisenberg
left a comment
There was a problem hiding this comment.
We're populating the changelog now. Since this is a public-facing feature, could you add an entry. And then it's good to merge. Thanks!
Sorry, something went wrong.
There shouldn't be an entry. This is just for internal tests. CodeQL for Ruby is not available yet. |
Sorry, something went wrong.
Merge / deployment checklist