Use commander preAction hook for setMode - #536
Merged
aeisenberg merged 1 commit intoJun 2, 2021
Merged
aeisenberg merged 1 commit into
aeisenberg merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
force-pushed
the
aeisenberg/commander
branch
from
c1db8b7 to
f49e9ca
Compare
June 1, 2021 18:15
Hooks are new to commander v8. We can use hooks to ensure that `setMode` is called before every command is invoked.
aeisenberg
force-pushed
the
aeisenberg/commander
branch
from
f49e9ca to
539d968
Compare
June 1, 2021 18:19
adityasharad
approved these changes
Jun 1, 2021
adityasharad
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice. Do any of our runner tests check the version?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
No. We have no tests for that. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hooks are new to commander v8. We can use hooks to ensure that setMode
is called before every command is invoked.
Merge / deployment checklist