Remove quotes around $DRAFT argument - #553
Merged
aeisenberg merged 1 commit intoJun 7, 2021
Merged
aeisenberg merged 1 commit into
aeisenberg merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
adityasharad
approved these changes
Jun 7, 2021
adityasharad
reviewed
Jun 7, 2021
Comment thread
.github/workflows/post-release-mergeback.yml
Outdated
| --title "$PR_TITLE" \ | ||
| --body "$PR_BODY" \ | ||
| "$DRAFT" | ||
| $DRAFT # no quotes around $DRAFT. gh will error out if there is an empty "" |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Alternatively: ${DRAFT:+"$DRAFT"}
Sorry, something went wrong.
gh will complain if there is an empty `""`, which is the case if `$DRAFT` is unset.
aeisenberg
force-pushed
the
aeisenberg/no-quotes
branch
from
906165e to
74764ac
Compare
June 7, 2021 20:53
aeisenberg
enabled auto-merge
June 7, 2021 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh will complain if there is an empty "", which is the case if
$DRAFT is unset.
Merge / deployment checklist