Add --finalize-dataset to database finalize call - #558
Merged
edoardopirovano merged 2 commits intoJun 9, 2021
Merged
edoardopirovano merged 2 commits into
edoardopirovano merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
approved these changes
Jun 9, 2021
edoardopirovano
enabled auto-merge (rebase)
June 9, 2021 15:42
This was referenced Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a minor change to the database finalize call the Action makes by adding the --finalize-dataset flag to it. This allows us to free up some space on disk, at the expense of not being able to import further data into the dataset. This is okay, however, because the Action does not import further TRAP files after calling finalize.
Merge / deployment checklist