Fix C# line counting and add test - #586
Merged
aeisenberg merged 4 commits intoJun 24, 2021
Merged
aeisenberg merged 4 commits into
aeisenberg merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
edoardopirovano
force-pushed
the
csharp-loc
branch
from
7618995 to
68b6873
Compare
June 23, 2021 22:39
aeisenberg
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #584
This PR will fix our line counting for C# once aeisenberg/linguist#1 which fixes the underlying issue has been merged and a new release of github-linguist has been made to npm.
Merge / deployment checklist