Add new packs input to init action - #591
aeisenberg merged 3 commits into
Conversation
Sorry, something went wrong.
This input allows users to specify which packs to run. It works in unison with the packs block of the config file and it is similar to how `queries` works. They both use `+` in the same way. Note that the `#TODO` in the pr check is still around, but the CLI is available. I will remove the TODO in the next commit.
edoardopirovano
left a comment
There was a problem hiding this comment.
Nice! This mostly looks good, a few comments inline.
Sorry, something went wrong.
| if (packsInput.startsWith("+")) { | ||
| packsInput = packsInput.substring(1).trim(); | ||
| if (!packsInput) { | ||
| throw new Error("Remove the '+' from the packs input."); |
There was a problem hiding this comment.
This could be a little more informative, e.g. A + was used in the packs input to specify that you wished to add some packs to your CodeQL analysis. However, no packs were specified. Please either remove the + or specify some packs.
Sorry, something went wrong.
There was a problem hiding this comment.
@aeisenberg Think you missed this comment? Unless you disagree, in which case no need to address it 🙂
Sorry, something went wrong.
There was a problem hiding this comment.
Right. Missed this. Thanks for pointing it out.
Sorry, something went wrong.
| - uses: ./../action/init | ||
| with: | ||
| config-file: ".github/codeql/codeql-config-packaging3.yml" | ||
| packs: dsp-testing/codeql-pack1@0.0.4 |
There was a problem hiding this comment.
I think you need a + here? Otherwise this LGTM now.
Sorry, something went wrong.
There was a problem hiding this comment.
Doh!
Sorry, something went wrong.
|
Build is failing because the version of the cli it is grabbing from the toolcache is not yet new enough to support all of the packaging commands. |
Sorry, something went wrong.
Also, update the options and inputs documentation.
This input allows users to specify which packs to run. It works in
unison with the packs block of the config file and it is similar to
how queries works. They both use + in the same way.
Note that the #TODO in the pr check is still around, but the CLI
is available. I will remove the TODO in the next commit.
Merge / deployment checklist