Restore original getCodeQLActionRepository behaviour - #594
Merged
aeisenberg merged 3 commits intoJun 24, 2021
Merged
aeisenberg merged 3 commits into
aeisenberg merged 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
aeisenberg
approved these changes
Jun 24, 2021
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for catching and fixing this bug!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
We didn't catch this earlier because all of our integration tests run within actions and the RUNNER_TEMP variable is already set. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 1.0.0 the logic for determining the getCodeQLActionRepository worked this way round:
https://github.com/github/codeql-action/blob/v1.0.0/src/codeql.ts#L139
In the latest version this logic was reversed during refactoring:
https://github.com/github/codeql-action/blob/v1.0.3/src/codeql.ts#L182
This is currently causing the codeql-runner to break with the error message:
RUNNER_TEMP environment variable must be set.
This PR restores the original behaviour.
Merge / deployment checklist