Add a quick way to disable builtin queries - #61
Merged
robertbrignull merged 1 commit intoJun 15, 2020
Merged
robertbrignull merged 1 commit into
robertbrignull merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
chrisgavin
approved these changes
Jun 15, 2020
chrisgavin
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks Robert! This looks very useful. :)
Sorry, something went wrong.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is way for us, the maintainers of the action, to quickly disable built-in queries without having to go through the process of changing the codeql bundle release. This can be used as a temporary measure while the code scanning suite is changed and the bundle updated, which could take a couple of weeks.
You can verify it's working by looking in the logs on the integration test runs (e.g. https://github.com/github/codeql-action/runs/772313587).
It prints out how many queries are run and you can see that there are two fewer C# queries compared to than a run against master (e.g. https://github.com/github/codeql-action/runs/772066021)
Merge / deployment checklist