Update databases URL - #612
Merged
robertbrignull merged 3 commits intoJul 14, 2021
Merged
robertbrignull merged 3 commits into
robertbrignull merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
robertbrignull
force-pushed
the
robertbrignull/databases_url
branch
from
35023f2 to
b0b9ab8
Compare
July 13, 2021 13:10
robertbrignull
marked this pull request as ready for review
July 13, 2021 13:12
aeisenberg
reviewed
Jul 13, 2021
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks fine, except for the code scanning warning.
Sorry, something went wrong.
Comment thread
src/database-upload.ts
Outdated
aeisenberg
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're changing the URL used to upload databases to include "codeql" as well as "code scanning". This should make it more clear what the URL is for and unnecessarily box us in if we want to add other aspects to this API. The API side has been updated to allow both the old and new URLs, so now we can change things over here.
Merge / deployment checklist