FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add matrix input to init action by robertbrignull · Pull Request #65 · github/codeql-action · GitHub

/ codeql-action Public

Add matrix input to init action - #65

Merged
robertbrignull merged 2 commits into
masterfrom
init_missing_matrix
Jun 16, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Add matrix input to init action#65
robertbrignull merged 2 commits into
masterfrom
init_missing_matrix

Conversation

robertbrignull commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

I think this input is missing. It is used to construct the status reports.

Not sure how this is missing, especially as we have a query for it. Though to be fair we haven't gone through to eliminate all the cases of that as they are actually pretty benign in practice.

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

robertbrignull commented Jun 16, 2020

Copy link
Copy Markdown
Contributor Author

Sorry this PR may not make much sense. To review I think it's best to know that these inputs are used by the code to send status reports, and this is called from all actions. Then look at the action.yml files and note that all of them include both the matrix and token inputs, except for this one which is missing the matrix input. The effect this'll have is that the matrix isn't populated in the status reports, which isn't fatal and explains why we haven't noticed it until now.

sampart approved these changes Jun 16, 2020
View reviewed changes

sampart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Sorry for the delay in reviewing this.

robertbrignull commented Jun 16, 2020

Copy link
Copy Markdown
Contributor Author

1 fixed alert. Excellent. That's what I expected
https://github.com/github/codeql-action/pull/65/checks?check_run_id=776340119

robertbrignull merged commit 6de3e1c into master Jun 16, 2020
robertbrignull deleted the init_missing_matrix branch June 17, 2020 14:56
github-actions Bot mentioned this pull request Jun 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
sampart sampart approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

sampart

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL