Update runner building dependencies - #663
Merged
edoardopirovano merged 1 commit intoJul 29, 2021
Merged
edoardopirovano merged 1 commit into
edoardopirovano merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
adityasharad
approved these changes
Jul 29, 2021
adityasharad
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Can we teach Dependabot to look in the subfolder?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
I'll look into it after this PR! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependencies we use when building the runner can't be automatically updated by Dependabot since they are in a package.json in a sub-folder rather than in the main one. Nonetheless, we should still occasionally update them. In particular, there is currently an alert on one of the transitive dependencies being affected by this CVE (GHSA-ww39-953v-wcq6), which I believe will be resolved by this update.