Create PRs as drafts to prompt maintainers to trigger PR checks - #679
Merged
henrymercer merged 2 commits intoAug 4, 2021
Merged
henrymercer merged 2 commits into
henrymercer merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
PR checks won't be triggered on PRs created by Actions workflows. Therefore mark PRs created by workflows as draft to prompt maintainers to take the PR out of draft, thereby triggering PR checks.
edoardopirovano
approved these changes
Aug 3, 2021
edoardopirovano
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
henrymercer
enabled auto-merge
August 3, 2021 17:39
Copy link
Copy Markdown
|
Heads up that you might also need to change the PR checks to run on ready_for_review! (We had a similar issue in the VS Code repo: github/vscode-codeql#888) |
Sorry, something went wrong.
henrymercer
disabled auto-merge
August 3, 2021 17:43
Copy link
Copy Markdown
Contributor
Author
|
Good call, thanks! |
Sorry, something went wrong.
This runs checks on reopened draft PRs to support triggering PR checks on draft PRs that were opened by other workflows.
Copy link
Copy Markdown
Contributor
Author
|
We won't be able to test the triggering behaviour until 2632b65 is in main, but this is ready for re-review. |
Sorry, something went wrong.
edoardopirovano
approved these changes
Aug 3, 2021
edoardopirovano
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice, good spot @shati-patel. Still LGTM 🙂
Sorry, something went wrong.
henrymercer
enabled auto-merge
August 4, 2021 09:05
webknjaz
added a commit
to ansible/pylibssh
that referenced
this pull request
Jun 7, 2024
Normally, PRs/commits published using the default GitHub Actions CI/CD API token are not propagated to any integrations. This patch marks the release PR as a draft and leaves a comment asking the maintainers to mark it as ready for review in order to actually trigger a CI run. This idea is found in GitHub's own repos: * github/codeql-action#2263 (comment) * https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41 * github/codeql-action#1868 * github/codeql-action#679
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jun 20, 2024
Normally, PRs/commits published using the default GitHub Actions CI/CD API token are not propagated to any integrations. This patch marks the plugin update PR as a draft and leaves a comment asking the maintainers to mark it as ready for review in order to actually trigger a CI run. This idea is found in GitHub's own repos: * github/codeql-action#2263 (comment) * https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41 * github/codeql-action#1868 * github/codeql-action#679
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jun 20, 2024
Normally, PRs/commits published using the default GitHub Actions CI/CD API token are not propagated to any integrations. This patch marks the plugin update PR as a draft and leaves a comment asking the maintainers to mark it as ready for review in order to actually trigger a CI run. This idea is found in GitHub's own repos: * github/codeql-action#2263 (comment) * https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41 * github/codeql-action#1868 * github/codeql-action#679
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jun 21, 2024
Normally, PRs/commits published using the default GitHub Actions CI/CD API token are not propagated to any integrations. This patch marks the plugin update PR as a draft and leaves a comment asking the maintainers to mark it as ready for review in order to actually trigger a CI run. This idea is found in GitHub's own repos: * github/codeql-action#2263 (comment) * https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41 * github/codeql-action#1868 * github/codeql-action#679
Glyphack
pushed a commit
to Glyphack/pytest
that referenced
this pull request
Jul 30, 2024
Normally, PRs/commits published using the default GitHub Actions CI/CD API token are not propagated to any integrations. This patch marks the plugin update PR as a draft and leaves a comment asking the maintainers to mark it as ready for review in order to actually trigger a CI run. This idea is found in GitHub's own repos: * github/codeql-action#2263 (comment) * https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41 * github/codeql-action#1868 * github/codeql-action#679
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checks aren't triggered on PRs created by Actions workflows. This change marks PRs created by workflows as draft to prompt maintainers to take the PR out of draft, thereby triggering PR checks.
Update release branch workflow:
Post-release mergeback workflow:
Merge / deployment checklist