Always run the latest tools PR checks so we can make them required - #699
Merged
henrymercer merged 2 commits intoAug 11, 2021
Merged
henrymercer merged 2 commits into
henrymercer merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
edoardopirovano
approved these changes
Aug 11, 2021
edoardopirovano
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change runs integration tests with all three bundles, even if tools: latest would be the same as tools: null (i.e. omitting the tools property). This allows us to make integration tests against each one of these three tools configurations required status checks on PRs.
As future work, we could move the "$CODEQL_VERSION_DEFAULT" == "$CODEQL_VERSION_LATEST" logic into jobs running with tools: latest to minimise redundant work, or investigate depending on statuses rather than Actions jobs. However right now the additional cost created by these redundant jobs doesn't seem to justify the complexity.
Merge / deployment checklist