Reduce the number of PR checks that are run on push - #700
Merged
henrymercer merged 1 commit intoAug 11, 2021
Merged
henrymercer merged 1 commit into
henrymercer merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
henrymercer
force-pushed
the
henrymercer/reduce-num-pr-check-jobs-on-push
branch
from
13ca0e2 to
4eeb458
Compare
August 11, 2021 15:19
henrymercer
marked this pull request as ready for review
August 11, 2021 15:23
edoardopirovano
approved these changes
Aug 11, 2021
edoardopirovano
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
henrymercer
enabled auto-merge
August 11, 2021 15:35
adityasharad
approved these changes
Aug 11, 2021
adityasharad
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Couple of minor suggestions.
Sorry, something went wrong.
Comment thread
.github/workflows/pr-checks.yml
Outdated
Comment thread
.github/workflows/pr-checks.yml
henrymercer
disabled auto-merge
August 11, 2021 15:36
If we're running on push, then we can reintroduce the logic that skips running with `tools: latest` when it would be the same as running with `tools: null`.
henrymercer
force-pushed
the
henrymercer/reduce-num-pr-check-jobs-on-push
branch
from
4eeb458 to
b19f1f9
Compare
August 11, 2021 16:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we're running on push, then we can reintroduce the logic that skips running with tools: latest when it would be the same as running with tools: null.
Merge / deployment checklist