FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Pass `--ram` flag to `database finalize` by edoardopirovano · Pull Request #702 · github/codeql-action · GitHub

/ codeql-action Public

Pass --ram flag to database finalize - #702

Merged
edoardopirovano merged 1 commit into
mainfrom
pass-ram-flag
Aug 12, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Pass --ram flag to database finalize#702
edoardopirovano merged 1 commit into
mainfrom
pass-ram-flag

Conversation

edoardopirovano commented Aug 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR passes a RAM option to database finalize, using the same logic to determine what value to use as we do for database run-queries. Currently, without a RAM option the JVM will determine it's own limit which is much more conservative than what we would do (i.e. use most of the memory available) leading to OOM errors during TRAP import for certain projects.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

edoardopirovano requested a review from a team as a code owner August 12, 2021 16:33
edoardopirovano mentioned this pull request Aug 12, 2021
Closed

edoardopirovano commented Aug 12, 2021

Copy link
Copy Markdown
Contributor Author

@cklin I opted for only using this option with CLI versions >=2.5.9 as, if I recall correctly, the flag was introduced in 2.5.8 but had a bug at that point. Is this correct?

henrymercer approved these changes Aug 12, 2021
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good modulo the discussion on the correct CodeQL version to check for before passing this flag.

Comment thread src/util.ts Outdated

cklin commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

@cklin I opted for only using this option with CLI versions >=2.5.9 as, if I recall correctly, the flag was introduced in 2.5.8 but had a bug at that point. Is this correct?

The bug fix https://github.com/github/semmle-code/pull/39696/commits/14b72e0439866c662cfdc1a9176ffad23b10a048 went into 2.5.8. And of course 2.5.9 works too.

edoardopirovano commented Aug 12, 2021

Copy link
Copy Markdown
Contributor Author

@cklin I opted for only using this option with CLI versions >=2.5.9 as, if I recall correctly, the flag was introduced in 2.5.8 but had a bug at that point. Is this correct?

The bug fix github/semmle-code@14b72e0 went into 2.5.8. And of course 2.5.9 works too.

Ah, okay, we can use 2.5.8 then! Thanks for checking that 🙂

edoardopirovano merged commit 01d17ea into main Aug 12, 2021
edoardopirovano deleted the pass-ram-flag branch August 12, 2021 17:25
github-actions Bot mentioned this pull request Aug 16, 2021
Merged
5 tasks
aliscco mentioned this pull request Apr 27, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL