| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
A few flags that are only available in recent CodeQL CLIs are moved to be behind a version check, so we can be compatible with older versions. @henrymercer I'd be very keen to have your eyes on this commit to let me know if you foresee any issues with not passing those flags (we don't need full functionality, but we shouldn't break either).
For --print-metrics-summary and --print-diagnostics-summary, these summaries are only printed when there are results from metrics or diagnostics queries respectively, so we already need to handle the situation where they're not printed.
For --sarif-group-rules-by-pack, Code Scanning should be able to handle receiving both SARIF that does and SARIF that doesn't group rules by the query pack they're from. However I'm unsure whether --sarif-category works without --sarif-group-rules-by-pack — ccing @cannist to confirm since I think you worked on the implementation of this.
Sorry, something went wrong.
I would be very surprised if these had an effect on each other, so I think this change is fine. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR bundles together a few commits that improve how the Action handles what CLI version is being used. In particular:
I think the integration tests workflow is in need of some refactoring now that I have added this additional complexity to it, but I propose delaying this to a later PR.