FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add names to all pr-checks by aeisenberg · Pull Request #713 · github/codeql-action · GitHub

/ codeql-action Public

Add names to all pr-checks - #713

Merged
aeisenberg merged 4 commits into
mainfrom
aeisenberg/pr-check-names
Sep 1, 2021
ConversationCommits (4)ChecksFiles changed
Merged

Add names to all pr-checks#713
aeisenberg merged 4 commits into
mainfrom
aeisenberg/pr-check-names

Conversation

aeisenberg commented Aug 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Small change to aid with debugging failing jobs. I tried to put the most important part of the name of each job first.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

aeisenberg requested a review from a team as a code owner August 24, 2021 23:26
adityasharad approved these changes Aug 24, 2021
View reviewed changes

adityasharad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe JavaScript -> JS and CSharp -> C# for brevity. Other than that LGTM.

adityasharad commented Aug 24, 2021

Copy link
Copy Markdown
Contributor

...and we have to update our branch protection rules 😆

aeisenberg force-pushed the aeisenberg/pr-check-names branch from 9fe2f7c to 88bc9ac Compare August 24, 2021 23:36

aeisenberg commented Aug 24, 2021

Copy link
Copy Markdown
Contributor Author

Maybe JavaScript -> JS and CSharp -> C# for brevity. Other than that LGTM.

Good call. Done.

aeisenberg commented Aug 24, 2021

Copy link
Copy Markdown
Contributor Author

...and we have to update our branch protection rules 😆

That's not a PR, though, is it?

aeisenberg enabled auto-merge August 24, 2021 23:38

aeisenberg commented Aug 24, 2021

Copy link
Copy Markdown
Contributor Author

Odd...does not seem to be showing the new names.

aeisenberg disabled auto-merge August 24, 2021 23:39
aeisenberg force-pushed the aeisenberg/pr-check-names branch from 88bc9ac to 1785bbb Compare August 25, 2021 17:38
aeisenberg enabled auto-merge August 25, 2021 17:39

edoardopirovano commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

I think automerge won't work due to the checks changing name?

adityasharad commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Yes, we have to change the Required checks in the branch protection rules in this repo's Settings page, to match the new check names.

aeisenberg closed this Sep 1, 2021
auto-merge was automatically disabled September 1, 2021 22:33

Pull request was closed

aeisenberg reopened this Sep 1, 2021
aeisenberg force-pushed the aeisenberg/pr-check-names branch from e567e17 to e22a6cd Compare September 1, 2021 22:34
aeisenberg enabled auto-merge September 1, 2021 22:43

aeisenberg commented Sep 1, 2021

Copy link
Copy Markdown
Contributor Author

Going to need this PR to be force-pushed. It is getting confused because it is expecting all check names to pass, when they no longer exist.

aeisenberg disabled auto-merge September 1, 2021 22:46
aeisenberg merged commit 62ef9f5 into main Sep 1, 2021
aeisenberg deleted the aeisenberg/pr-check-names branch September 1, 2021 22:47
github-actions Bot mentioned this pull request Sep 6, 2021
Merged
5 tasks
aliscco mentioned this pull request Apr 27, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

adityasharad adityasharad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL