Fixing sorting of PRs - #72
Merged
robertbrignull merged 2 commits intoJun 23, 2020
Merged
robertbrignull merged 2 commits into
robertbrignull merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
alexkappa
approved these changes
Jun 22, 2020
alexkappa
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a mistake here as I thought sorted updated the list in-place, but that's not true. So the PRs in #71 weren't sorted as they were inteneded to have been.
I got suspicious as to why I was the conductor, when I think it should have been @alexkappa
Merge / deployment checklist