Fix dependabot issues - #786
Merged
aeisenberg merged 2 commits intoNov 3, 2021
Merged
aeisenberg merged 2 commits into
aeisenberg merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
node_modules/.package-lock.json
| "bin": { | ||
| "semver": "bin/semver.js" | ||
| } | ||
| }, | ||
| "node_modules/@actions/tool-cache/node_modules/uuid": { | ||
| "version": "3.4.0", | ||
| "license": "MIT", | ||
| "integrity": "sha512-HjSDRw6gZE5JMggctHBcjVak08+KEVhSIiDzFnT9S9aegmp85S/bReBVTb4QTFaRNptJ9kuYaNhnbNEOkbKb/A==", | ||
| "deprecated": "Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Can we upgrade past this?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
It is a transitive dependency of actions/tool-cache, so not sure. But I will try.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This dependency is coming from https://github.com/actions/toolkit/blob/main/packages/tool-cache/package.json#L44. I raised an issue to request upgrading the dependency. actions/toolkit#925. There's not much I can do in this repo to fix it. It will need to be fixed in the dependency, which I will create a PR for.
Sorry, something went wrong.
aeisenberg
force-pushed
the
aeisenberg/dependabot
branch
from
85271fa to
531c6ba
Compare
October 25, 2021 15:56
cklin
approved these changes
Nov 2, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist