Change the update-dependencies workflow - #787
Closed
aeisenberg wants to merge 1 commit into
Closed
aeisenberg wants to merge 1 commit into
aeisenberg wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add more security. Don't run the workflow if the actor is incorrect, or there is a fork involved. And then only run the update dependencies after a manual approval.
Copy link
Copy Markdown
Contributor
|
Apologies... I only just saw this and have already merged #789 which does something similar. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Your PR is a better solution since it does not require user intervention. And, as we learned, the actions actor is not correct. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more security. Don't run the workflow if the actor is incorrect,
or there is a fork involved. And then only run the update dependencies
after a manual approval.
Merge / deployment checklist